Allow <.input type="checkbox">
without value
attr in core components
#5427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Currently, the
<.input type="checkbox">
in the core components is "unsafe" to use from a DX point of view:Using
<.input type="checkbox" checked={true} />
without an attributevalue="…"
raises a runtime exception because thevalue
key is not in assigns.The
@value
is not a required attr in thedef input
, yet, thedef input
for checkbox was pattern matching for it in the function argument, so thevalue
attr is de facto required even if announced optional.I can’t see why the
value
is mandatory, the body of the function is barely using it as a fallback if@checked
is not set. So I propose to just dropping it from the function pattern matching, and later check if present in the assigns map.See also this discussion I started on elixir forum before making this PR.
Thanks for your kind review 🙏 !