GH Actions: run tests also on Windows OS

[jrfnl]

When running the tests locally, I realized that patch #146 did not actually work correctly on Windows.

This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs.

Note: the lowest PHP version I can get a running build on is PHP 5.5. This is related to SSL transport issues with Packagist with old Composer versions (which are needed for old PHP versions).

---

⚠️ The above mentioned bug should be fixed & merged first before this PR can get a passing build.

[staabm]

I tried debugging this problem on my windows machine and this did not lead to anything useful.
I feel its a weird bug in php-src, which happens on windows because of running skip-linting.php via proc_open.

Opened a php-src bug with my observations so far

[cmb69]

PHP-Parallel-Lint/tests/Unit/ParallelLintLintTest.php

Line 86 in 0c27060

$this->assertSame(0, $result->getCheckedFilesCount());

looks wrong to me; shouldn't the expectation be 1?

[staabm]

thanks for looking into it.

looks wrong to me; shouldn't the expectation be 1?

as I understood the test, expectations are:

• we try to lint example.php
• since example.php contains a <?php // lint < 5.3 header and we are running with PHP >= 5.3, it should be considered "skipped"

-> thats why

        $this->assertSame(0, $result->getCheckedFilesCount());
        $this->assertSame(0, $result->getFilesWithSyntaxErrorCount());
        $this->assertSame(1, $result->getSkippedFilesCount());

look correct to me.

because of the problems described in php/php-src#16147 I think parallel-lint via skip-linting.php does not see the "skip-condition" // lint < 5.3 and therefore the test fails

[cmb69]

Indeed, the expectation is apparently correct. Sorry for the noise.