Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing parallel execution of tasks #586

Closed
wants to merge 13 commits into from

Conversation

paslandau
Copy link

@paslandau paslandau commented Jan 7, 2019

Q A
Branch seventies
Bug fix? no
New feature? yes
BC breaks? no (hopefully?)
Deprecations? no
Documented? no (poc => please feedback)
Fixed tickets #584,#581,#580,#394

tl;dr

  • made some bigger changes to allow parallel execution of tasks
  • currently only works for external tasks - internal tasks like the linting would have to be exposed as a command line executable
  • introduced e2e/integration tests (because I don't know PhpSpec :D)
  • for this "test", I added some depencies to composer.json and added a grumphp_parallel.yml,
    so you can run composer install && vendor/bin/grumphp run --config="grumphp_parallel.yml"
    to see the thing in action. I also add verbosity output to see the actual command, see
    vendor/bin/grumphp run --config="grumphp_parallel.yml" -vvv (messy, but helpful for understanding a task)
  • this is a POC and I realise that I might have a somewhat different coding style, sorry for that.
    I don't cling to any of the implemenation, I just wanted to get something "runnable" to get an impression
    of how a parallel execution might look like and I think that this might actually be a pretty nice
    extension to grumphp :)

See https://github.com/paslandau/grumphp/blob/parallel/CHANGELOG.md for further info.

@Landerstraeten Landerstraeten changed the base branch from grumpy-seventies to master February 28, 2019 15:22
@veewee veewee mentioned this pull request Feb 14, 2020
40 tasks
@veewee
Copy link
Contributor

veewee commented May 26, 2020

Parallel tasks are implemented in #741. Already borrowed the good ideas from this PR already :) Thanks!

@veewee veewee closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants