-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved task runner #741
Merged
Merged
Improved task runner #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Landerstraeten : Can you take a quick look at this? It's still in an early phase and quite experimental - but wanted your early feedback. It looks like this approach should be something I could get to work. |
This should fix issue #755 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on an improved task runner system.
Goals:
FixableResult
+ middleware that fixes failed tasks (but does not commit ! )Call to undefined function _HumbugBoxc0ef9bc7da1a\Amp\Promise\wait() in phar
$this in object context
$this in object context
Parallel test container:
Upgrading
Validated GrumPHP parameters
The new version will validate the structure and content of the GrumPHP parameters.
Therefor you need to move the grumphp parameters out of the regular parameters section.
If you are not using any
symfony/dependency-injection
parameters, you only need to rename the parameters keyword:Removed support for PHP-CS-Fixer v1.
Since PHP-CS-Fixer is out for quite some time and because v3 is in the making, we drop support for version 1.
If you still want to use version 1, you can use an older version of GrumPHP or provide a custom extension for your project.
By default, the
phpcsfixer
will now load the task for the latest PHP-CS-fixer.We also provided a
phpcsfixer2
alias to make sure existing projects don't break.However, you can now rename the task inside your configuration:
We added a way of running the PHP-CS-Fixer v1 in parallel to improve execution speed.
However, this code is not needed anymore inside the new version and might be confusing with the actual parallel implementation.
Therefore, we removed following parameters:
Bump to Symfony 4.4
In this release, we bump the dependencies up to Symfony 4.4.
This is because the parallel system requires the Advanced console output improvements inside SF 4.1. Since that version is not supported by Symfony anymore, we decided to bump to the version 4 LTS.
If your package still requires older dependencies, you can install the grumphp-shim package which works dependency-less.