Resolve the env vars for conventions #760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add an E2E test for this to make sure it works as expected? |
ashokadewit
pushed a commit
to mediact/testing-suite
that referenced
this pull request
May 29, 2020
This fixes: ``` The option "strict" with value "%composer.strict%" is expected to be of type "bool", but is of type "string". ``` A pull request exists on phpro/grumphp#760 which also fixes this issue. When that pull request has been merged this extension can be removed.
|
This has been tested in #741 as well, and seems to be resolved there. Conventions will be usable again when this PR is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue