Provide option to run a single/list of tasks from the config #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Jan 7, 2019
src/Console/Command/RunCommand.php
Outdated
| * @param string $value | ||
| * @return string[] | ||
| */ | ||
| protected function parseCommaSeparatedOption(string $value) |
There was a problem hiding this comment.
It is better to move this method to the \GrumPHP\Util\Str class.
Maybe something like:
public static function explodeWithCleanup(string $delimiter, string $string): array
This way the logic can be tested in a normal way and it is reusable if we want to add more comma separated options?
|
Hi @paslandau. Thanks for your PR! Can you rebase against master? I will review it soon. |
Landerstraeten
force-pushed
the
580_seventies
branch
2 times, most recently
from
55dadde
to
51bab84
Compare
veewee
reviewed
Apr 19, 2019
| @@ -0,0 +1,63 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Add e2e tests instead; (this namespace is not in a testsuite)
src/Collection/TasksCollection.php
Outdated
| public function filterByTaskNames(array $tasks): self | ||
| { | ||
| if (empty($tasks)) { | ||
| return new self($this->toArray()); |
There was a problem hiding this comment.
return $this; ? No need to create a new instance in that case right?
Landerstraeten
force-pushed
the
580_seventies
branch
from
e76708e
to
e3fc41d
Compare
Landerstraeten
approved these changes
May 16, 2019
veewee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580