Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains edited from Black/Whitelist page lose Group assignment #2260

Closed
yubiuser opened this issue Jul 11, 2022 · 9 comments · Fixed by #2261
Closed

Domains edited from Black/Whitelist page lose Group assignment #2260

yubiuser opened this issue Jul 11, 2022 · 9 comments · Fixed by #2261
Labels
Bug: Confirmed Fixed In Next Release WIP

Comments

@yubiuser
Copy link
Member

See https://discourse.pi-hole.net/t/domains-lose-group-assignment-if-enabled-disabled-modified-on-blacklist-management-page/56474

Two approaches: fix the bug or get rid of the separat black/whitelist pages
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/domains-lose-group-assignment-if-enabled-disabled-modified-on-blacklist-management-page/56474/3

@yubiuser yubiuser linked a pull request Jul 11, 2022 that will close this issue
Fix editing domains from blacklist/whitelist pages #2261
Merged
1 task
@yubiuser yubiuser added the WIP label Jul 11, 2022
@yubiuser
Copy link
Member Author

As the fix was so easy, I did not remove the pages entirely.

@yubiuser yubiuser changed the title Domains edited from Black/Whitelist page loose Group assignment Domains edited from Black/Whitelist page lose Group assignment Jul 11, 2022
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/blacklist-is-being-ignored-since-update-last-week/56517/15

@yubiuser
Copy link
Member Author

We decided to get rid of the separate pages: #2266

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/exact-blacklist-entry-not-working/56659/2

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/enable-disable-whitelist-item-does-not-work-after-update/56679/2

@yubiuser yubiuser mentioned this issue Jul 28, 2022
Closed
@jfb-pihole jfb-pihole mentioned this issue Aug 1, 2022
Closed
3 tasks
@yubiuser yubiuser mentioned this issue Aug 10, 2022
Closed
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-blockt-nicht/57063/3

@jfb-pihole jfb-pihole mentioned this issue Aug 17, 2022
Closed
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/blacklist-bug-after-enable-disable-reproducible/57177/2

@yubiuser
Copy link
Member Author

yubiuser commented Sep 2, 2022

Fix released with https://discourse.pi-hole.net/t/pi-hole-ftl-v5-17-web-v5-14-and-core-v5-12-released/57497

@yubiuser yubiuser closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Confirmed Fixed In Next Release WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix editing domains from blacklist/whitelist pages pi-hole/web
2 participants
@yubiuser @pralor-bot