-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dedicated black/whitelist pages + redesign menu #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
force-pushed
the
remove/black_whitelist
branch
from
July 16, 2022 09:08
3394ac9
to
f8e25e1
Compare
yubiuser
changed the title
Remove/black whitelist
Remove dedicated black/whitelist pages
Jul 16, 2022
That's where I took it from but deliberately added the |
Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
force-pushed
the
remove/black_whitelist
branch
from
July 16, 2022 12:20
96866fa
to
6a1e590
Compare
yubiuser
added
the
PR: Code Review Required
Open Pull Request, needs code reviewed
label
Jul 16, 2022
Ready for review. I guess there might be more code that could go... |
Signed-off-by: Christian König <ckoenig@posteo.de>
rdwebdesign
requested changes
Jul 17, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
…me always-true if-clauses Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
changed the title
Remove dedicated black/whitelist pages
Remove dedicated black/whitelist pages + redesign menu
Jul 17, 2022
DL6ER
previously approved these changes
Jul 17, 2022
DL6ER
added
PR: Approved
Open Pull Request, Approved by required number of reviewers
and removed
PR: Code Review Required
Open Pull Request, needs code reviewed
labels
Jul 17, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
DL6ER
approved these changes
Jul 17, 2022
rdwebdesign
approved these changes
Jul 17, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the separate Black/Whitelist pages from the nav menu. They have been there to aid new users and to make the transition pre-v5 -> v5 more easy. It was always planed to remove them at some point.
They have been only a font-end for
groups-domais.php
where thegroup
column was hidden.The whole functionality can still be accessed via
Group Management
->Domains
.After removing the two entries the menu looked quite empty so I re-structured it a bit. Additional, added a link to our Discourse forum.
Remove now unused code.
By submitting this pull request, I confirm the following:
git rebase
)