Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Content-Security-Policy meta tag #2287

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Remove Content-Security-Policy meta tag #2287

merged 1 commit into from
Aug 21, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 7, 2022

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

Remove Content-Security-Policy meta tag. We're setting this now as HTTP header which is the preferred way.

To be merged after pi-hole/pi-hole#4862 has been approved/merged.

  • How does this PR accomplish the above?:

Remove the tag.

  • What documentation changes (if any) are needed to support this PR?:

None


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…TP header which is the preferred way.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added PR: Approval Required Open Pull Request, needs approval PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Aug 7, 2022
@DL6ER
Copy link
Member Author

DL6ER commented Aug 9, 2022

Waiting on pi-hole/pi-hole#4862 to be merged, first.

@rdwebdesign
Copy link
Member

@DL6ER

The header.php file was changed in devel branch, but the changes aren't showing in the diff.
I think this needs a local rebase.

@DL6ER
Copy link
Member Author

DL6ER commented Aug 21, 2022

This isn't important, the diff is only generated on opening or when a conflict arose. This PR can still be merged as is.

@DL6ER DL6ER merged commit 844e24b into devel Aug 21, 2022
@DL6ER DL6ER deleted the tweak/CSP-meta branch August 21, 2022 06:17
@rdwebdesign rdwebdesign mentioned this pull request Aug 22, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants