Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Background:
In 2 previous PRs, the pi-hole icon was introduced as an inline SVG in more than one place (the code was duplicated).
Later, the code was improved to avoid the duplication, using an SVG symbol.
The symbol needed to be inline (inside the HTML), because the Content-Security-Policy didn't allow the use of
<use xlink:href="">
tag with external SVG files.safari-pinned-tab.svg
icon, reducing it's size;How does this PR accomplish the above?:
Now, after the new config introduced by pi-hole/pi-hole#4862 and #2287, it is possible to move the SVG code to an external file.
The
safari-pinned-tab.svg
was reduced after simplifying the icon paths and optimizing the file.What documentation changes (if any) are needed to support this PR?:
none
By submitting this pull request, I confirm the following:
git rebase
)