Change ForeignKeyAction to enum in the generator #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #359 +/- ##
===========================================
+ Coverage 82.83% 83.05% +0.22%
===========================================
Files 68 68
Lines 1660 1682 +22
===========================================
+ Hits 1375 1397 +22
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vitusortner
reviewed
Jun 15, 2020
|
I put the extension on |
vitusortner
reviewed
Jun 19, 2020
mqus
added a commit
to mqus/floor
that referenced
this pull request
Jun 20, 2020
… onConflict values
vitusortner
previously approved these changes
Aug 1, 2020
… onConflict values
Also fix formatting from rebase
mqus
force-pushed
the
refactor/change-to-foreignkeyaction-enum
branch
from
50855a3
to
c5ebdf9
Compare
…-foreignkeyaction-enum # Conflicts: # floor_generator/lib/misc/extension/dart_object_extension.dart # floor_generator/lib/processor/entity_processor.dart
|
@mqus I'll look into getting this one merged if you don't mind? |
vitusortner
changed the title
vitusortner
approved these changes
Nov 22, 2020
|
Thank you! |
vitusortner
added a commit
that referenced
this pull request
Dec 19, 2020
* Change ForeignKeyAction to enum in the generator (#359) * Added support for WITH statements for DatabaseViews (#443) * Documentation update on DateTimeConverter sample (#442) * Make foreign key mapping null safe Co-authored-by: mqus <8398165+mqus@users.noreply.github.com> Co-authored-by: themadmrj <themadmrj@users.noreply.github.com> Co-authored-by: Cássio Seffrin <cassioseffrin@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ForeignKeyAction to be an enum instead of a string. This allows us to be more strict when processing the annotation as well as be more confident when dealing with annotations.
This is a preparation for the sqlanalyzer, to avoid matching strings when converting floor entities to moor/sqlparser tables.