Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make foreign key mapping null safe #451

Merged
merged 5 commits into from
Dec 19, 2020

Conversation

vitusortner
Copy link
Collaborator

No description provided.

mqus and others added 5 commits November 22, 2020 21:37
# Conflicts:
#	floor_generator/lib/misc/extension/foreign_key_action_extension.dart
#	floor_generator/lib/processor/entity_processor.dart
#	floor_generator/lib/processor/error/entity_processor_error.dart
#	floor_generator/lib/processor/insertion_method_processor.dart
#	floor_generator/lib/processor/update_method_processor.dart
#	floor_generator/lib/value_object/foreign_key.dart
#	floor_generator/test/misc/foreign_key_action_test.dart
#	floor_generator/test/mocks.dart
#	floor_generator/test/value_object/entity_test.dart
#	floor_generator/test/value_object/foreign_key_test.dart
@vitusortner vitusortner changed the title Nullsafe foreign key action mapping Make foreign key mapping null safe Dec 19, 2020
@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #451 (84b6517) into nullsafety (0af0b1b) will increase coverage by 0.54%.
The diff coverage is 97.50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           nullsafety     #451      +/-   ##
==============================================
+ Coverage       83.04%   83.59%   +0.54%     
==============================================
  Files              68       68              
  Lines            1646     1670      +24     
==============================================
+ Hits             1367     1396      +29     
+ Misses            279      274       -5     
Flag Coverage Δ
floor 83.59% <97.50%> (+0.54%) ⬆️
floor_generator 82.98% <97.50%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/misc/extension/foreign_key_action_extension.dart 85.71% <85.71%> (ø)
...ator/lib/misc/extension/dart_object_extension.dart 100.00% <100.00%> (ø)
...loor_generator/lib/processor/entity_processor.dart 80.00% <100.00%> (+0.28%) ⬆️
...or/lib/processor/error/entity_processor_error.dart 16.12% <100.00%> (+12.42%) ⬆️
...ator/lib/processor/insertion_method_processor.dart 89.18% <100.00%> (+0.95%) ⬆️
...nerator/lib/processor/update_method_processor.dart 83.33% <100.00%> (+1.51%) ⬆️
floor_generator/lib/processor/view_processor.dart 100.00% <100.00%> (+4.34%) ⬆️
floor_generator/lib/value_object/foreign_key.dart 66.66% <100.00%> (ø)
floor_generator/lib/processor/field_processor.dart 87.87% <0.00%> (+0.37%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af0b1b...84b6517. Read the comment docs.

@vitusortner vitusortner marked this pull request as ready for review December 19, 2020 14:20
@vitusortner vitusortner merged commit 7b2ef20 into nullsafety Dec 19, 2020
@vitusortner vitusortner deleted the nullsafe-foreign-key-action-mapping branch December 19, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants