Changed settings page theme #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nikhil7174
commented
Mar 30, 2024
•
Nikhil7174
commented
- Changed brave-toolbar-gradient color
- Changed brave iron-icon and iron selected color
- Changed brave-brand-color
- Changed cr-link-color
|
Can you add some screenshots in the PR for your changes |
| @@ -97,7 +98,7 @@ RegisterStyleOverride( | |||
|
|
|||
| @media (prefers-color-scheme: dark) { | |||
| :host { | |||
| --settings-nav-item-color: #F4F4F4 !important; | |||
| --settings-nav-item-color: #f4f4f4 !important; | |||
There was a problem hiding this comment.
Why are we using lower case letters here? this does not change anything right?
There was a problem hiding this comment.
bhaiya mostly i think this happened because of formattor. i will revert it .
| @@ -6,10 +6,10 @@ | |||
| /* Default/light theme button colors */ | |||
| :host(:not([style])) { | |||
| --brave-text-color: #3b3e4f; /* grey800 */ | |||
| --brave-brand-color: #ff7654; /* orange400 */ | |||
| --brave-primary-hover: #ff977d; /* orange300 */ | |||
| --brave-brand-color: #27a348; /* orange400 */ | |||
There was a problem hiding this comment.
please change the comment here as well to reflect the changed colour
udaybansal19
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.