Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed settings page theme #13

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Changed settings page theme #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21a42af
Changed settings page theme
Nikhil7174 Mar 30, 2024
4a39ed0
added names of colors used
Nikhil7174 Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions browser/resources/settings/brave_overrides/settings_menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ RegisterStyleOverride(
}

.cr-nav-menu-item[selected] {
--iron-icon-fill-color: var(--leo-gradient-icons-active);
// --iron-icon-fill-color: var(--leo-gradient-icons-active);
--iron-icon-fill-color: #27a348;

color: var(--cr-link-color) !important;
background: transparent !important;
Expand All @@ -97,7 +98,7 @@ RegisterStyleOverride(

@media (prefers-color-scheme: dark) {
:host {
--settings-nav-item-color: #F4F4F4 !important;
--settings-nav-item-color: #f4f4f4 !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using lower case letters here? this does not change anything right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bhaiya mostly i think this happened because of formattor. i will revert it .

border-color: transparent !important;
background-color: #161719;
}
Expand All @@ -121,12 +122,12 @@ RegisterStyleOverride(
}

a[href].iron-selected {
color: #DB2F04;
color: #db2f04;
font-weight: 400 !important;
}

a:hover, iron-icon:hover {
color: #444DD0 !important;
color: #47d789 !important;
}

iron-icon, leo-icon {
Expand All @@ -144,7 +145,7 @@ RegisterStyleOverride(
display: block;
height: 32px;
width: 4px;
background: linear-gradient(96.98deg, #E51D00 0%, #E5007B 78.13%);
background: linear-gradient(96.98deg, #27a348 0%, #27c5a1 78.13%);
border-radius: 0px 2px 2px 0px;
}

Expand All @@ -154,7 +155,7 @@ RegisterStyleOverride(
}

a:hover, iron-icon:hover {
color: #A6ABE9 !important;
color: #47d789 !important;
}
}

Expand Down
2 changes: 1 addition & 1 deletion ui/webui/resources/br_elements/br_shared_vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ html {
--interactive-color: var(--cr-link-color) !important;
--brave-focus-outline: auto 3px var(--flat-focus-shadow-color);
--disabled-color: rgb(241, 243, 244);
--cr-link-color: rgb(255, 69, 48) !important;
--cr-link-color: rgb(27, 185, 99) !important;
--cr-link-color-rgb: 255, 69, 48;
--flat-focus-shadow-color: rgba(255, 69, 48, .4) !important;
--cr-selectable-focus_-_outline: var(--brave-focus-outline) !important;
Expand Down
2 changes: 1 addition & 1 deletion ui/webui/resources/css/md_colors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
html {
--brave-toolbar-gradient: linear-gradient(-90deg, #A3278F 0%, #E52F50 100%); /* linear gradient: red500 -> magenta600 */
--brave-toolbar-gradient: linear-gradient(-90deg, #27a348 0%, #27c5a1 100%); /* linear gradient: red500 -> magenta600 */
--md-background-color: rgb(233, 236, 239); /* neutral200 */
--md-loading-message-color: #5E6175; /* grey700 */
--md-toolbar-color: rgb(200, 44, 109); /* not design system color. middle value of toolbar's linear gradient. */
Expand Down
6 changes: 3 additions & 3 deletions ui/webui/resources/overrides/cr_button_override.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
/* Default/light theme button colors */
:host(:not([style])) {
--brave-text-color: #3b3e4f; /* grey800 */
--brave-brand-color: #ff7654; /* orange400 */
--brave-primary-hover: #ff977d; /* orange300 */
--brave-brand-color: #27a348; /* orange400 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the comment here as well to reflect the changed colour

--brave-primary-hover: #55d821; /* orange300 */
--brave-default-hover: rgba(255, 118, 84, 0.1); /* orange400 */
--brave-focus-outline: rgba(255, 118, 84, 0.4); /* orange400 */
--brave-focus-outline: rgba(84, 255, 121, 0.4); /* orange400 */
--ink-color: var(--brave-brand-color) !important;
--text-color: var(--brave-text-color) !important;
--text-color-action: white !important;
Expand Down
Loading