Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

summary/: export new log collector #602

Merged
merged 4 commits into from
Nov 19, 2020
Merged

summary/: export new log collector #602

merged 4 commits into from
Nov 19, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

dumpling wants to use collector. But the logger is different.

What is changed and how it works?

export log exporter for dumpling to specify its own logger.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@lichunzhu lichunzhu changed the title export log exporter summary/: export log exporter Nov 17, 2020
@lichunzhu lichunzhu changed the title summary/: export log exporter summary/: export new log collector Nov 17, 2020
kennytm
kennytm reviewed Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix lint. rest lgtm.

[2020-11-17T11:59:19.487Z] pkg/summary/collector.go:85:1: Top level comment should end in a period (godot)

[2020-11-17T11:59:19.488Z] // NewLogCollector returns a new LogCollector

[2020-11-17T11:59:19.488Z] ^

@lichunzhu
Copy link
Contributor Author

/rebuild

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@kennytm kennytm added the status/LGT1 LGTM1 label Nov 19, 2020
@lichunzhu
Copy link
Contributor Author

/rebuild

@lichunzhu
Copy link
Contributor Author

/run-all-tests

2 similar comments
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

3pointer
3pointer approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Nov 19, 2020
@lichunzhu lichunzhu merged commit bb4294d into pingcap:master Nov 19, 2020
@lichunzhu lichunzhu deleted the exportLogCollector branch November 19, 2020 10:11
@ti-srebot ti-srebot mentioned this pull request Nov 19, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #604

lichunzhu pushed a commit that referenced this pull request Nov 19, 2020
@ti-srebot
summary/: export new log collector (#602) (#604)
6001023 
* export log exporter
* make sure dumpling can redirect log in progress.go
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@3pointer 3pointer 3pointer approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lichunzhu @ti-srebot @kennytm @3pointer