Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

summary/: export new log collector (#602) #604

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #602 to release-4.0


What problem does this PR solve?

dumpling wants to use collector. But the logger is different.

What is changed and how it works?

export log exporter for dumpling to specify its own logger.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 19, 2020
@lichunzhu
Copy link
Contributor

/rebuild

Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Nov 19, 2020
@lichunzhu lichunzhu merged commit 6001023 into pingcap:release-4.0 Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants