Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: improve coverage to 71.4% for pkg/conn (#1010) #1015

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1010 to release-2.0


What problem does this PR solve?

part of #998

What is changed and how it works?

improve coverage to 71.4% for pkg/conn

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 10, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Sep 10, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 10, 2020
@csuzhangxc csuzhangxc merged commit 627a3c6 into pingcap:release-2.0 Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants