Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: refine and improve pkg/utils unit test coverage to 82.3% #1054

Merged
merged 26 commits into from
Sep 23, 2020
Merged

test: refine and improve pkg/utils unit test coverage to 82.3% #1054

merged 26 commits into from
Sep 23, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

part of #998

What is changed and how it works?

  • add unit test cases
  • tiny refine code

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress labels Sep 17, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

lance6716
lance6716 reviewed Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Makefile Outdated Show resolved Hide resolved
@csuzhangxc @lance6716
Update Makefile
64ac701 
Co-authored-by: lance6716 <lance6716@gmail.com>
@csuzhangxc csuzhangxc changed the title test: improve pkg/utils unit test coverage and tiny refine [WIP] test: improve pkg/utils unit test coverage and tiny refine Sep 17, 2020
@csuzhangxc
*: fix makefile
efc5068
@csuzhangxc
makefile: goveralls may fail, so put it later
2bae392
@csuzhangxc
utils: add test cases for FetchAllDoTables and refine code
6e714f4
@csuzhangxc
Merge branch 'master' into ut-cov-util
f8f3055
@csuzhangxc
*: add more test cases for common.go
33de239
@csuzhangxc
*: more test cases for common.go
3000a86
@csuzhangxc
*: add some test cases for db.go
fd587e1
@csuzhangxc
*: more test cases for db.go
6a2974e
@csuzhangxc
Merge branch 'master' into ut-cov-util
6b2ff9b
@csuzhangxc
*: refine MySQL error usage
063c3d3
@csuzhangxc
*: fix ErrBadConn
35511cb
@csuzhangxc
*: add test case for encrypt.go
f3da7de
@csuzhangxc
*: fix ErrBadConn
a24f7b6
@csuzhangxc
*: add test cases for file.go
6889973
@csuzhangxc
*: add test case for hash.go
5e3916a
@csuzhangxc
*: add test cases for printer.go
fc0d506
@csuzhangxc
*: add test case for GenFakeRotateEvent
d0b036b
@csuzhangxc
*: add test case for storage.go
1689715
@csuzhangxc
*: move JoinProcessErrors and add test case
06eb7a0
@csuzhangxc
*: add test cases for util.go
9578d5d
@csuzhangxc csuzhangxc changed the title [WIP] test: improve pkg/utils unit test coverage and tiny refine test: refine and improve pkg/utils unit test coverage to 82.3$ Sep 22, 2020
@csuzhangxc csuzhangxc changed the title test: refine and improve pkg/utils unit test coverage to 82.3$ test: refine and improve pkg/utils unit test coverage to 82.3% Sep 22, 2020
@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Sep 22, 2020
lance6716
lance6716 reviewed Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/utils/db_test.go Show resolved Hide resolved
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 23, 2020
GMHDBJD
GMHDBJD approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 23, 2020
@csuzhangxc csuzhangxc merged commit ee6c6c2 into pingcap:master Sep 23, 2020
@csuzhangxc csuzhangxc deleted the ut-cov-util branch September 23, 2020 07:06
@csuzhangxc csuzhangxc added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 23, 2020
@csuzhangxc
Copy link
Member Author

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Sep 23, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1080

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 23, 2020
GMHDBJD pushed a commit that referenced this pull request Sep 23, 2020
@ti-srebot
test: refine and improve pkg/utils unit test coverage to 82.3% (#1054) (
43d5ad7 
#1080)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @lance6716 @ti-srebot @GMHDBJD