This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
improve coverage for syncer/sharding_group.go to 82.4% #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
changed the title
lance6716
added
needs-cherry-pick-release-2.0
csuzhangxc
reviewed
Sep 23, 2020
syncer/sharding_group.go
Outdated
| @@ -557,9 +542,11 @@ func (k *ShardingGroupKeeper) UnresolvedTables() (map[string]bool, [][]string) { | |||
| tables := make([][]string, 0, 10) | |||
| k.RLock() | |||
| defer k.RUnlock() | |||
| // TODO: where does k.groups delete its key? | |||
There was a problem hiding this comment.
Can we delete the key after all tables/schemas leave the group (the group becomes empty)?
csuzhangxc
added
status/LGT1
|
/run-all-tests |
GMHDBJD
added
status/LGT2
|
cherry pick to release-2.0 in PR #1082 |
ti-srebot
added
already-cherry-pick-2.0
csuzhangxc
pushed a commit
that referenced
this pull request
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #998
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes