This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
add dumpling unit test #1115
Merged
add dumpling unit test #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
csuzhangxc
reviewed
Sep 28, 2020
|
/run-all-test |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
csuzhangxc
reviewed
Sep 30, 2020
dumpling/dumpling_test.go
Outdated
Comment on lines
110
to
117
| var wg sync.WaitGroup | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| dumpling.Process(ctx, resultCh) | ||
| }() | ||
| cancel() | ||
| wg.Wait() |
There was a problem hiding this comment.
the extra goroutine can still be removed?
|
/run-all-tests |
lance6716
reviewed
Oct 9, 2020
dumpling/dumpling_test.go
Outdated
| c.Assert(len(resultCh), Equals, 1) | ||
| result := <-resultCh | ||
| c.Assert(result.IsCanceled, IsFalse) | ||
| c.Assert(len(result.Errors), Equals, 0, Commentf("errors: %v", result.Errors)) |
There was a problem hiding this comment.
don't forget to remove this Commentf since it's zero-length
dumpling/dumpling_test.go
Outdated
|
|
||
| func (d *testDumplingSuite) TestDumpling(c *C) { | ||
| dumpling := NewDumpling(d.cfg) | ||
| ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) |
There was a problem hiding this comment.
how about only use WithTimeout in third dumpling.Process, I'm afraid when CI runs slowly it will fail
csuzhangxc
added
status/LGT1
|
LGTM |
lance6716
approved these changes
Oct 9, 2020
lance6716
added
the
needs-cherry-pick-release-2.0
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Oct 9, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1131 |
ti-srebot
added
already-cherry-pick-2.0
csuzhangxc
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #998
What is changed and how it works?
add dumpling ut
Check List
Tests