Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: improve coverage for syncer/ddl.go to 85.1% (#1109) #1120

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1109 to release-2.0


What problem does this PR solve?

part of #998

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 30, 2020
@lance6716
Copy link
Collaborator

/run-all-tests

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Sep 30, 2020

/run-all-tests

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Sep 30, 2020
@csuzhangxc csuzhangxc merged commit b779584 into pingcap:release-2.0 Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants