Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check-task: precheck server-id for all/incremental mode #1312

Merged
merged 3 commits into from
Nov 27, 2020
Merged

check-task: precheck server-id for all/incremental mode #1312

merged 3 commits into from
Nov 27, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Nov 27, 2020

What problem does this PR solve?

close #1288

What is changed and how it works?

precheck server-id for all/incremental mode

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    test with server-id not set

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Nov 27, 2020
@GMHDBJD GMHDBJD added this to the v2.0.1 milestone Nov 27, 2020
@GMHDBJD GMHDBJD added the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label Nov 27, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Nov 27, 2020
csuzhangxc
csuzhangxc approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 27, 2020
@GMHDBJD GMHDBJD merged commit 2b14028 into pingcap:master Nov 27, 2020
@GMHDBJD GMHDBJD deleted the precheckServerId branch November 27, 2020 13:19
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Nov 27, 2020
@GMHDBJD @ti-srebot
cherry pick pingcap#1312 to release-2.0
17978b0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 27, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1315

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Nov 27, 2020
csuzhangxc pushed a commit that referenced this pull request Nov 27, 2020
@ti-srebot @GMHDBJD
check-task: precheck server-id for all/incremental mode (#1312) (#1315)
eee7853 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-docs The docs related to this PR already updated. Add this label once the docs are updated status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

check whether server-id set in upstream MySQL for all/incremental mode
4 participants
@GMHDBJD @lance6716 @ti-srebot @csuzhangxc