Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check-task: precheck server-id for all/incremental mode (#1312) #1315

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1312 to release-2.0


What problem does this PR solve?

close #1288

What is changed and how it works?

precheck server-id for all/incremental mode

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    test with server-id not set

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Nov 27, 2020
@ti-srebot ti-srebot requested a review from csuzhangxc November 27, 2020 13:19
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 27, 2020
@csuzhangxc csuzhangxc merged commit eee7853 into pingcap:release-2.0 Nov 27, 2020
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated first-time-contributor type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants