Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: refine dmctl output for DM-master, task-name and config-file #291

Merged
merged 1 commit into from
Sep 18, 2019
Merged

*: refine dmctl output for DM-master, task-name and config-file #291

merged 1 commit into from
Sep 18, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Sep 17, 2019 •
edited
Loading

What problem does this PR solve?

refine some name in the output of dmctl to match pingcap/docs-cn#1878

What is changed and how it works?

  • rename dm-master to DM-master
  • rename task_name to task-name
  • rename config_file to config-file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • run commands in dmctl, observe the output

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #291 into master will increase coverage by 0.0135%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #291        +/-   ##
================================================
+ Coverage   60.0027%   60.0162%   +0.0135%     
================================================
  Files           134        134                
  Lines         14766      14766                
================================================
+ Hits           8860       8862         +2     
+ Misses         5060       5059         -1     
+ Partials        846        845         -1

@csuzhangxc
Copy link
Member Author

@amyangfei @3pointer PTAL

@csuzhangxc csuzhangxc mentioned this pull request Sep 17, 2019
Merged
amyangfei
amyangfei reviewed Sep 17, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 17, 2019
IANTHEREAL
IANTHEREAL approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL merged commit 4c39a6b into pingcap:master Sep 18, 2019
@csuzhangxc csuzhangxc deleted the refine-dmctl-output branch September 18, 2019 06:35
csuzhangxc added a commit to csuzhangxc/dm that referenced this pull request Sep 18, 2019
@csuzhangxc
*: refine dmctl output for DM-master, task-name and config-file (…
108b6db 
…pingcap#291)

(cherry picked from commit 4c39a6b)
@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 18, 2019
@csuzhangxc csuzhangxc mentioned this pull request Sep 18, 2019
Merged
csuzhangxc added a commit that referenced this pull request Sep 23, 2019
@csuzhangxc
*: refine dmctl output for DM-master, task-name and config-file (…
43f2d07 
…#291) (#292)
@csuzhangxc csuzhangxc added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Sep 23, 2019
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc @IANTHEREAL
*: refine dmctl output for DM-master, task-name and config-file (…
513f063 
…pingcap#291)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @amyangfei @IANTHEREAL