Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: refine dmctl output for DM-master, task-name and config-file (#291) #292

Merged
merged 3 commits into from
Sep 23, 2019
Merged

*: refine dmctl output for DM-master, task-name and config-file (#291) #292

merged 3 commits into from
Sep 23, 2019

Conversation

csuzhangxc
Copy link
Member

cherry-pick #291

What problem does this PR solve?

refine some name in the output of dmctl to match pingcap/docs-cn#1878

What is changed and how it works?

  • rename dm-master to DM-master
  • rename task_name to task-name
  • rename config_file to config-file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • run commands in dmctl, observe the output

@csuzhangxc csuzhangxc added priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring labels Sep 18, 2019
amyangfei
amyangfei reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
btw we use git cherry-pick <comit hash> and keep the same commit message between cherry-pick pr and the picked pr

@amyangfei amyangfei added the status/LGT1 One reviewer already commented LGTM label Sep 18, 2019
@csuzhangxc csuzhangxc changed the title cherry-pick: refine dmctl output for DM-master, task-name and config-file *: refine dmctl output for DM-master, task-name and config-file (#291) Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #292 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #292   +/-   ##
==============================================
  Coverage      60.0243%   60.0243%           
==============================================
  Files              134        134           
  Lines            14769      14769           
==============================================
  Hits              8865       8865           
  Misses            5059       5059           
  Partials           845        845

WangXiangUSTC
WangXiangUSTC approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 23, 2019
@csuzhangxc csuzhangxc merged commit 43f2d07 into pingcap:release-1.0 Sep 23, 2019
@csuzhangxc csuzhangxc deleted the refine-dmctl-output-1.0 branch September 23, 2019 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

Assignees
No one assigned
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @amyangfei @WangXiangUSTC