-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
================================================
+ Coverage 60.2407% 60.2542% +0.0135%
================================================
Files 134 134
Lines 14789 14789
================================================
+ Hits 8909 8911 +2
+ Misses 5043 5042 -1
+ Partials 837 836 -1 |
@amyangfei @WangXiangUSTC PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will all output be changed to DM-worker
, such as
https://github.com/pingcap/dm/blob/master/dm/ctl/master/break_ddl_lock.go#L54
sounds good. should we need to changed to |
I feel ok to change to |
@amyangfei changed to other places including:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW I prefer to keep dm-worker
in error class name
, log, which is more tidy.
Comparing
[code=40066:class=dm-worker:scope=internal:level=high] ExecuteDDL timeout, try use
query-status to query whether the DDL is still blocking
[code=40066:class=DM-worker:scope=internal:level=high] ExecuteDDL timeout, try use
query-status to query whether the DDL is still blocking
(cherry picked from commit ce5e038)
What problem does this PR solve?
refine dmctl comands' usage text
What is changed and how it works?
refine usage suggestion from I18N team in pingcap/docs-cn#1878.
Check List
Tests
Related changes