Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: refine commands' usage text (#296) #302

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

csuzhangxc
Copy link
Member

cherry-pick #296

What problem does this PR solve?

refine dmctl comands' usage text

What is changed and how it works?

refine usage suggestion from I18N team in pingcap/docs-cn#1878.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    1. run dmctl
    2. observe the output of usage

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring labels Sep 25, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #302 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #302   +/-   ##
==============================================
  Coverage      60.0243%   60.0243%           
==============================================
  Files              134        134           
  Lines            14769      14769           
==============================================
  Hits              8865       8865           
  Misses            5059       5059           
  Partials           845        845

@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @amyangfei PTAL

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 25, 2019
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 26, 2019
@csuzhangxc csuzhangxc merged commit 5068c87 into pingcap:release-1.0 Sep 26, 2019
@csuzhangxc csuzhangxc deleted the dmctl-refine-usage-1.0 branch September 26, 2019 03:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants