*: support running unit test on Windows

Makefile

@@ -17,10 +17,15 @@ FAILPOINT_DIR := $$(for p in $(PACKAGES); do echo $${p\#"github.com/pingcap/dm/"
 FAILPOINT := bin/failpoint-ctl
 
 RACE_FLAG =
+TEST_RACE_FLAG = -race
 ifeq ("$(WITH_RACE)", "1")
 	RACE_FLAG = -race
 	GOBUILD   = CGO_ENABLED=1 $(GO) build
 endif
+ifeq ("$(WITH_RACE)", "0")
+	TEST_RACE_FLAG =
+	GOTEST         = CGO_ENABLED=0 $(GO) test
+endif
 
 FAILPOINT_ENABLE  := $$(echo $(FAILPOINT_DIR) | xargs $(FAILPOINT) enable >/dev/null)
 FAILPOINT_DISABLE := $$(find $(FAILPOINT_DIR) | xargs $(FAILPOINT) disable >/dev/null)
@@ -34,7 +39,7 @@ ifeq ($(ARCH), $(LINUX))
 	LDFLAGS += -X "github.com/pingcap/dm/dm/master.SampleConfigFile=$(shell cat dm/master/dm-master.toml | base64 -w 0)"
 else
 	LDFLAGS += -X "github.com/pingcap/dm/dm/worker.SampleConfigFile=$(shell cat dm/worker/dm-worker.toml | base64)"
-	LDFLAGS += -X "github.com/pingcap/dm/dm/master.SampleConfigFile=$(shell cat dm/master/dm-master.toml | base64)" 
+	LDFLAGS += -X "github.com/pingcap/dm/dm/master.SampleConfigFile=$(shell cat dm/master/dm-master.toml | base64)"
 endif
 
 .PHONY: build test unit_test dm_integration_test_build integration_test \
@@ -65,7 +70,7 @@ unit_test:
 	which $(FAILPOINT) >/dev/null 2>&1 || $(GOBUILD) -o $(FAILPOINT) github.com/pingcap/failpoint/failpoint-ctl
 	$(FAILPOINT_ENABLE)
 	@export log_level=error; \
-	$(GOTEST) -covermode=atomic -coverprofile="$(TEST_DIR)/cov.unit_test.out" -race $(PACKAGES) \
+	$(GOTEST) -covermode=atomic -coverprofile="$(TEST_DIR)/cov.unit_test.out" $(TEST_RACE_FLAG) $(PACKAGES) \
 	|| { $(FAILPOINT_DISABLE); exit 1; }
 	$(FAILPOINT_DISABLE)
 
@@ -98,19 +103,19 @@ terror_check:
 dm_integration_test_build:
 	which $(FAILPOINT) >/dev/null 2>&1 || $(GOBUILD) -o $(FAILPOINT) github.com/pingcap/failpoint/failpoint-ctl
 	$(FAILPOINT_ENABLE)
-	$(GOTEST) -c -race -cover -covermode=atomic \
+	$(GOTEST) -c $(TEST_RACE_FLAG) -cover -covermode=atomic \
 		-coverpkg=github.com/pingcap/dm/... \
 		-o bin/dm-worker.test github.com/pingcap/dm/cmd/dm-worker \
 		|| { $(FAILPOINT_DISABLE); exit 1; }
-	$(GOTEST) -c -race -cover -covermode=atomic \
+	$(GOTEST) -c $(TEST_RACE_FLAG) -cover -covermode=atomic \
 		-coverpkg=github.com/pingcap/dm/... \
 		-o bin/dm-master.test github.com/pingcap/dm/cmd/dm-master \
 		|| { $(FAILPOINT_DISABLE); exit 1; }
 	$(GOTEST) -c -cover -covermode=count \
 		-coverpkg=github.com/pingcap/dm/... \
 		-o bin/dmctl.test github.com/pingcap/dm/cmd/dm-ctl \
 		|| { $(FAILPOINT_DISABLE); exit 1; }
-	$(GOTEST) -c -race -cover -covermode=atomic \
+	$(GOTEST) -c $(TEST_RACE_FLAG) -cover -covermode=atomic \
 		-coverpkg=github.com/pingcap/dm/... \
 		-o bin/dm-tracer.test github.com/pingcap/dm/cmd/dm-tracer \
 		|| { $(FAILPOINT_DISABLE); exit 1; }

pkg/streamer/file_test.go

@@ -19,6 +19,7 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
+	"regexp"
 	"sync"
 	"time"
 
@@ -218,7 +219,7 @@ func (t *testFileSuite) TestGetFirstBinlogName(c *C) {
 
 	// sub directory not exist
 	name, err := getFirstBinlogName(baseDir, uuid)
-	c.Assert(err, ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(name, Equals, "")
 
 	// empty directory
@@ -271,7 +272,7 @@ func (t *testFileSuite) TestFileSizeUpdated(c *C) {
 
 	// file not exists
 	cmp, err := fileSizeUpdated(filePath, latestSize)
-	c.Assert(err, ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(cmp, Equals, 0)
 
 	// create and write the file
@@ -313,7 +314,7 @@ func (t *testUtilSuite) TestRelaySubDirUpdated(c *C) {
 
 	// a. relay log dir not exist
 	upNotExist, err := relaySubDirUpdated(ctx, watcherInterval, "/not-exists-directory", "/not-exists-filepath", "not-exists-file", 0)
-	c.Assert(err, ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(upNotExist, Equals, "")
 
 	// create relay log dir
@@ -334,7 +335,7 @@ func (t *testUtilSuite) TestRelaySubDirUpdated(c *C) {
 
 	// c. latest file path not exist
 	upNotExist, err = relaySubDirUpdated(ctx, watcherInterval, subDir, "/no-exists-filepath", relayFiles[0], 0)
-	c.Assert(err, ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(upNotExist, Equals, "")
 
 	// 1. file increased when adding watching
@@ -476,7 +477,7 @@ func (t *testFileSuite) TestNeedSwitchSubDir(c *C) {
 	currentUUID = UUIDs[0]
 	needSwitch, needReParse, nextUUID, nextBinlogName, err = needSwitchSubDir(
 		relayDir, currentUUID, latestFilePath, latestFileSize, UUIDs)
-	c.Assert(err, ErrorMatches, fmt.Sprintf(".*%s.*no such file or directory.*", UUIDs[1]))
+	c.Assert(err, ErrorMatches, fmt.Sprintf(".*%s.*(no such file or directory|The system cannot find the file specified).*", UUIDs[1]))
 	c.Assert(needSwitch, IsFalse)
 	c.Assert(needReParse, IsFalse)
 	c.Assert(nextUUID, Equals, "")
@@ -493,7 +494,9 @@ func (t *testFileSuite) TestNeedSwitchSubDir(c *C) {
 	latestFilePath = filepath.Join(relayDir, UUIDs[0], "mysql-bin.000001")
 	needSwitch, needReParse, nextUUID, nextBinlogName, err = needSwitchSubDir(
 		relayDir, currentUUID, latestFilePath, latestFileSize, UUIDs)
-	c.Assert(err, ErrorMatches, fmt.Sprintf(".*%s.*no such file or directory.*", latestFilePath))
+	c.Assert(err, ErrorMatches, fmt.Sprintf(
+		".*%s.*(no such file or directory|The system cannot find the path specified).*",
+		regexp.QuoteMeta(latestFilePath)))
 	c.Assert(needSwitch, IsFalse)
 	c.Assert(needReParse, IsFalse)
 	c.Assert(nextUUID, Equals, "")

pkg/streamer/hub_test.go

@@ -14,6 +14,8 @@
 package streamer
 
 import (
+	"path/filepath"
+
 	. "github.com/pingcap/check"
 )
 
@@ -49,7 +51,7 @@ func (t *testHubSuite) TestRelayLogInfo(c *C) {
 
 	// string representation
 	rli3.UUID = "c6ae5afe-c7a3-11e8-a19d-0242ac130006.000001"
-	c.Assert(rli3.String(), Equals, rli3.UUID+"/"+rli3.Filename)
+	c.Assert(rli3.String(), Equals, filepath.Join(rli3.UUID, rli3.Filename))
 }
 
 func (t *testHubSuite) TestRelayLogInfoHub(c *C) {

pkg/streamer/reader_test.go

@@ -82,7 +82,7 @@ func (t *testReaderSuite) TestParseFileBase(c *C) {
 	// relay log file not exists, failed
 	needSwitch, needReParse, latestPos, nextUUID, nextBinlogName, err = r.parseFile(
 		ctx, s, filename, offset, relayDir, firstParse, currentUUID, possibleLast)
-	c.Assert(err, ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, ErrorMatches, ".*(no such file or directory|The system cannot find the path specified).*")
 
 	// empty relay log file, failed, got EOF
 	err = os.MkdirAll(relayDir, 0700)

pkg/utils/storage.go

@@ -13,48 +13,9 @@
 
 package utils
 
-import (
-	"reflect"
-
-	"golang.org/x/sys/unix"
-
-	"github.com/pingcap/dm/pkg/terror"
-)
-
 // StorageSize represents the storage's capacity and available size
 // Learn from tidb-binlog source code.
 type StorageSize struct {
 	Capacity  uint64
 	Available uint64
 }
-
-// GetStorageSize gets storage's capacity and available size
-func GetStorageSize(dir string) (size StorageSize, err error) {
-	var stat unix.Statfs_t
-
-	err = unix.Statfs(dir, &stat)
-	if err != nil {
-		return size, terror.ErrStatFileSize.Delegate(err)
-	}
-
-	// When container is run in MacOS, `bsize` obtained by `statfs` syscall is not the fundamental block size,
-	// but the `iosize` (optimal transfer block size) instead, it's usually 1024 times larger than the `bsize`.
-	// for example `4096 * 1024`. To get the correct block size, we should use `frsize`. But `frsize` isn't
-	// guaranteed to be supported everywhere, so we need to check whether it's supported before use it.
-	// For more details, please refer to: https://github.com/docker/for-mac/issues/2136
-	bSize := uint64(stat.Bsize)
-	field := reflect.ValueOf(&stat).Elem().FieldByName("Frsize")
-	if field.IsValid() {
-		if field.Kind() == reflect.Uint64 {
-			bSize = field.Uint()
-		} else {
-			bSize = uint64(field.Int())
-		}
-	}
-
-	// Available blocks * size per block = available space in bytes
-	size.Available = stat.Bavail * bSize
-	size.Capacity = stat.Blocks * bSize
-
-	return
-}

pkg/utils/storage_unix.go

@@ -0,0 +1,55 @@
+// Copyright 2019 PingCAP, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// +build !windows
+
+package utils
+
+import (
+	"reflect"
+
+	"golang.org/x/sys/unix"
+
+	"github.com/pingcap/dm/pkg/terror"
+)
+
+// GetStorageSize gets storage's capacity and available size
+func GetStorageSize(dir string) (size StorageSize, err error) {
+	var stat unix.Statfs_t
+
+	err = unix.Statfs(dir, &stat)
+	if err != nil {
+		return size, terror.ErrStatFileSize.Delegate(err)
+	}
+
+	// When container is run in MacOS, `bsize` obtained by `statfs` syscall is not the fundamental block size,
+	// but the `iosize` (optimal transfer block size) instead, it's usually 1024 times larger than the `bsize`.
+	// for example `4096 * 1024`. To get the correct block size, we should use `frsize`. But `frsize` isn't
+	// guaranteed to be supported everywhere, so we need to check whether it's supported before use it.
+	// For more details, please refer to: https://github.com/docker/for-mac/issues/2136
+	bSize := uint64(stat.Bsize)
+	field := reflect.ValueOf(&stat).Elem().FieldByName("Frsize")
+	if field.IsValid() {
+		if field.Kind() == reflect.Uint64 {
+			bSize = field.Uint()
+		} else {
+			bSize = uint64(field.Int())
+		}
+	}
+
+	// Available blocks * size per block = available space in bytes
+	size.Available = stat.Bavail * bSize
+	size.Capacity = stat.Blocks * bSize
+
+	return
+}

pkg/utils/storage_windows.go

@@ -0,0 +1,42 @@
+// Copyright 2019 PingCAP, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// +build windows
+
+package utils
+
+import (
+	"syscall"
+	"unsafe"
+
+	"github.com/pingcap/dm/pkg/terror"
+)
+
+var (
+	kernel32            = syscall.MustLoadDLL("kernel32.dll")
+	getDiskFreeSpaceExW = kernel32.MustFindProc("GetDiskFreeSpaceExW")
+)
+
+// GetStorageSize gets storage's capacity and available size
+func GetStorageSize(dir string) (size StorageSize, err error) {
+	r, _, e := getDiskFreeSpaceExW.Call(
+		uintptr(unsafe.Pointer(syscall.StringToUTF16Ptr(dir))),
+		uintptr(unsafe.Pointer(&size.Available)),
+		uintptr(unsafe.Pointer(&size.Capacity)),
+		0,
+	)
+	if r == 0 {
+		err = terror.ErrStatFileSize.Delegate(e)
+	}
+	return
+}

relay/writer/file_test.go

@@ -357,7 +357,7 @@ func (t *testFileWriterSuite) TestRotateEventWithFormatDescriptionEvent(c *check
 
 	// write again, duplicate, but we already rotated and new binlog file not created
 	_, err = w4.WriteEvent(rotateEv)
-	c.Assert(err, check.ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, check.ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 
 	// cfg.Filename should contain both one FormatDescriptionEvent and one RotateEvent, next file should be empty
 	filename1 = filepath.Join(cfg.RelayDir, cfg.Filename)

relay/writer/file_util_test.go

@@ -42,7 +42,7 @@ func (t *testFileUtilSuite) TestCheckBinlogHeaderExist(c *check.C) {
 	// file not exists
 	filename := filepath.Join(c.MkDir(), "test-mysql-bin.000001")
 	exist, err := checkBinlogHeaderExist(filename)
-	c.Assert(err, check.ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, check.ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(exist, check.IsFalse)
 
 	// empty file
@@ -99,7 +99,7 @@ func (t *testFileUtilSuite) TestCheckFormatDescriptionEventExist(c *check.C) {
 	// file not exists
 	filename := filepath.Join(c.MkDir(), "test-mysql-bin.000001")
 	exist, err := checkFormatDescriptionEventExist(filename)
-	c.Assert(err, check.ErrorMatches, ".*no such file or directory.*")
+	c.Assert(err, check.ErrorMatches, ".*(no such file or directory|The system cannot find the file specified).*")
 	c.Assert(exist, check.IsFalse)
 
 	// empty file