This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: support running unit test on Windows #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
priority/unimportant
kennytm
force-pushed
the
kennytm/windows-unit-test
branch
from
3b12f57 to
be7a062
Compare
|
/run-all-tests |
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
===========================================
Coverage 57.6864% 57.6864%
===========================================
Files 162 162
Lines 16373 16373
===========================================
Hits 9445 9445
Misses 6004 6004
Partials 924 924 |
csuzhangxc
added
status/LGT1
WangXiangUSTC
added
status/LGT2
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
pushed a commit
to csuzhangxc/dm
that referenced
this pull request
Dec 11, 2019
(cherry picked from commit ffd159f)
csuzhangxc
added a commit
that referenced
this pull request
Dec 11, 2019
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Supports running (not necessarily passing)
make unit_teston Windows (because etcd doesn't work on WSL).What is changed and how it works?
DM only has one non-Windows dependency which is computing the free space. Generalized this to work on Windows too.
Also, relaxed some tests which rely on Unix-specific error messages.
Check List
Tests
Code changes
Side effects
Related changes