Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: cherry pick #378 and #416 #418

Merged
merged 2 commits into from
Dec 11, 2019
Merged

*: cherry pick #378 and #416 #418

merged 2 commits into from
Dec 11, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Dec 11, 2019 •
edited
Loading

What problem does this PR solve?

split unit test according to upstream MySQL

What is changed and how it works?

cherry pick #378 and #416 (both of them modify the same line in Makefile).

Check List

Tests

  • Unit test
  • Integration test

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/test Changes related to test cases labels Dec 11, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@55ab839). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release-1.0       #418   +/-   ##
================================================
  Coverage               ?   57.2347%           
================================================
  Files                  ?        159           
  Lines                  ?      16172           
  Branches               ?          0           
================================================
  Hits                   ?       9256           
  Misses                 ?       6010           
  Partials               ?        906

@csuzhangxc csuzhangxc closed this Dec 11, 2019
@csuzhangxc csuzhangxc reopened this Dec 11, 2019
@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @kennytm PTAL

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

kennytm
kennytm reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 11, 2019
WangXiangUSTC
WangXiangUSTC approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 11, 2019
@csuzhangxc csuzhangxc merged commit 914dab5 into pingcap:release-1.0 Dec 11, 2019
@csuzhangxc csuzhangxc deleted the pick-416 branch December 11, 2019 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/test Changes related to test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @kennytm @WangXiangUSTC