Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: split unit test according to upstream MySQL #416

Merged
merged 5 commits into from
Dec 11, 2019
Merged

*: split unit test according to upstream MySQL #416

merged 5 commits into from
Dec 11, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Dec 10, 2019 •
edited
Loading

What problem does this PR solve?

  • when multi test cases in different test suite write data in the upstream, the binlog may become out of order.
  • run all unit test cases in one job in CI is a little slow.

What is changed and how it works?

  • split unit tests according to pkg (in Makefile), and now split them into:
    • unit_test_relay
    • unit_test_syncer
    • unit_test_pkg_binlog
    • unit_test_others
  • update jenkins pipeline

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/test Changes related to test cases needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Dec 10, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #416 into master will decrease coverage by 0.0296%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #416        +/-   ##
================================================
- Coverage   57.5014%   57.4718%   -0.0296%     
================================================
  Files           165        165                
  Lines         16890      16890                
================================================
- Hits           9712       9707         -5     
- Misses         6225       6230         +5     
  Partials        953        953

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Dec 10, 2019
@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @amyangfei PTAL

amyangfei
amyangfei reviewed Dec 10, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

amyangfei
amyangfei reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 10, 2019
WangXiangUSTC
WangXiangUSTC approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 11, 2019
@csuzhangxc csuzhangxc merged commit 10bafb3 into pingcap:master Dec 11, 2019
@csuzhangxc csuzhangxc deleted the split-unit-test branch December 11, 2019 03:40
@sre-bot
Copy link

sre-bot commented Dec 11, 2019

cherry pick to release-1.0 failed

csuzhangxc added a commit to csuzhangxc/dm that referenced this pull request Dec 11, 2019
@csuzhangxc
*: split unit test according to upstream MySQL (pingcap#416)
e2d32ee 
(cherry picked from commit 10bafb3)
@csuzhangxc csuzhangxc mentioned this pull request Dec 11, 2019
Merged
@csuzhangxc csuzhangxc added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Dec 11, 2019
csuzhangxc added a commit that referenced this pull request Dec 11, 2019
@csuzhangxc
*: cherry pick #378 and #416 (#418)
914dab5
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
*: split unit test according to upstream MySQL (pingcap#416)
c41e339
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/test Changes related to test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @sre-bot @amyangfei @WangXiangUSTC