Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.2] zh: add an alerting rule #569

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Conversation

lance6716
Copy link
Contributor

What is changed, added, or deleted? (Required)

align with pingcap/dm#1438

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CharLotteiu CharLotteiu added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/DNM status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Feb 24, 2021
@CharLotteiu CharLotteiu self-assigned this Feb 24, 2021
@CharLotteiu CharLotteiu requested a review from GMHDBJD March 3, 2021 05:37
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

zh/handle-alerts.md Outdated Show resolved Hide resolved
lance6716 and others added 2 commits March 3, 2021 13:39
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@CharLotteiu CharLotteiu mentioned this pull request Mar 4, 2021
7 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 4, 2021
@ti-srebot
Copy link
Contributor

@CharLotteiu, @GMHDBJD, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@CharLotteiu, @GMHDBJD, PTAL.

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 8, 2021
@CharLotteiu CharLotteiu merged commit 7f92602 into pingcap:master Mar 8, 2021
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Mar 8, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants