Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.2] zh: add an alerting rule (#569) #585

Merged
merged 2 commits into from
Apr 9, 2021
Merged

[2.0.2] zh: add an alerting rule (#569) #585

merged 2 commits into from
Apr 9, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 8, 2021 •
edited
Loading

cherry-pick #569 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In docs-dm repo:
git pr https://github.com/pingcap/docs-dm/pull/585

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs-dm.git pr/585:release-2.0-7f9260244f2a

What is changed, added, or deleted? (Required)

align with pingcap/dm#1438

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lance6716 @ti-srebot
cherry pick pingcap#569 to release-2.0
8147892 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
7 tasks
@ti-srebot ti-srebot added status/DNM status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR. labels Mar 8, 2021
@ti-srebot ti-srebot requested review from CharLotteiu and GMHDBJD March 8, 2021 07:48
@ti-srebot
Copy link
Contributor Author

@lance6716 you're already a collaborator in bot's repo.

@CharLotteiu CharLotteiu removed the status/PTAL This PR is ready for reviewing. label Mar 8, 2021
@ti-srebot
Copy link
Contributor Author

@GMHDBJD, @CharLotteiu, PTAL.

@ti-srebot
Copy link
Contributor Author

@GMHDBJD, @CharLotteiu, PTAL.

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@ti-srebot
Copy link
Contributor Author

@GMHDBJD, @CharLotteiu, PTAL.

@ti-srebot
Copy link
Contributor Author

@CharLotteiu, @GMHDBJD, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor Author

@CharLotteiu, @GMHDBJD, PTAL.

@ti-srebot
Copy link
Contributor Author

@CharLotteiu, @GMHDBJD, PTAL.

GMHDBJD
GMHDBJD reviewed Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot
Copy link
Contributor Author

@CharLotteiu, @GMHDBJD, PTAL.

@CharLotteiu
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@yikeke yikeke removed the status/DNM label Mar 24, 2021
@ti-srebot
Copy link
Contributor Author

@GMHDBJD, PTAL.

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2021
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0b2680d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@ti-chi-bot ti-chi-bot merged commit a34263e into pingcap:release-2.0 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@CharLotteiu CharLotteiu CharLotteiu approved these changes

Assignees

@lance6716 lance6716

Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @GMHDBJD @ti-chi-bot @CharLotteiu @lance6716 @yikeke