Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/sql/character-set: update examples #1259

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jun 24, 2019

What is changed, added or deleted?

The 3.0 and dev output shows only supported collations.
The 2.1 output includes all collations.

What is the related PR or file link(s)?

pingcap/tidb#10186

Which version does your change affect?

All

Check list

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

The 3.0 and dev output shows only supported collations.
The 2.1 output includes all collations.
@morgo morgo requested a review from kolbe June 24, 2019 20:09
Copy link
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit a9d4001 into pingcap:master Jun 24, 2019
@morgo morgo deleted the fix-misc branch June 24, 2019 21:18
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants