-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, infoschema: SHOW COLLATIONS
shows supported collations only
#10186
Conversation
Thank you for working on this. I think it's a great enhancement! |
@@ -861,7 +861,7 @@ func (e *ShowExec) fetchShowCreateDatabase() error { | |||
} | |||
|
|||
func (e *ShowExec) fetchShowCollation() error { | |||
collations := charset.GetCollations() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this function in parser now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable, I will try to remove it in another PR, thanks
LGTM |
@bb7133 Please merge master && resolve conflicts. BTW please add some proper labels for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix ci
The circle CI fail is misleading, it actually pass all tests |
a65e951
to
3c8bbf0
Compare
Codecov Report
@@ Coverage Diff @@
## master #10186 +/- ##
===============================================
+ Coverage 77.949% 77.9566% +0.0076%
===============================================
Files 407 407
Lines 83543 82601 -942
===============================================
- Hits 65121 64393 -728
+ Misses 13591 13431 -160
+ Partials 4831 4777 -54 |
/run-all-tests |
PTAL @crazycs520 @zz-jason |
What problem does this PR solve?
This PR aims to fix 2 compatibility issues:
SHOW CHARSET
command shows only supported charsets:But
SHOW COLLATIONS
shows all collations that supported in MySQL 5.7:It's better for
SHOW COLLATIONS
to display only supported collations.Default
column is wrong for some ofSHOW COLLATION
results:The default collation of
utf8
in TiDB isutf8_bin
What is changed and how it works?
This main change is from parser PR: pingcap/parser#295
Check List
Tests
Code changes
Side effects
SHOW
resultRelated changes