Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning: add max-open-engines description #1658

Merged
merged 4 commits into from
Nov 22, 2019

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 18, 2019

What is changed, added or deleted?

This PR updates the description of max-open-engines.
In the dev version of TiDB Lightning deployment doc, max-open-engines is removed in #1455.

What is the related PR or file link(s)?

pingcap/docs-cn#1978

Which version does your change affect?

v2.1, v3.0, v3.1

@TomShawn TomShawn added v2.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 18, 2019
@TomShawn TomShawn requested review from ericsyh and yikeke November 18, 2019 05:13
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit d2f5c94 into pingcap:master Nov 22, 2019
@TomShawn TomShawn deleted the lightning-max-open-files branch November 22, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants