reference: add a new config in tidb-server config doc #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
added
translation/from-docs-cn
ran-huang
reviewed
Apr 15, 2020
| @@ -34,6 +34,14 @@ The TiDB configuration file supports more options than command-line parameters. | |||
| + Default value: `<TMPDIR>/tidb/tmp-storage` | |||
| + It only takes effect when `oom-use-tmp-storage` is `true`. | |||
|
|
|||
| ### `temp-storage-quota` | |||
|
|
|||
| + Specifies the storage quota for the storage in `tmp-storage-path`. | |||
There was a problem hiding this comment.
- Two
storages seem redundant. - You miss the
bytesdescription.
| + When a single SQL statement uses a temporary disk and the total volume of the temporary disk of the TiDB server exceeds this configuration value, the current SQL operation is cancelled and the `Out of Global Storage Quota!` error is returned. | ||
| + When the value of this configuration is smaller than `0`, the above check and limit do not apply. | ||
| + Default value: `-1` | ||
| + When the remaining available storage in `tmp-storage-path` is lower than the value defined by `temp-storage-quota`, the TiDB server reports an error when it is started and exits. |
There was a problem hiding this comment.
To avoid ambiguity in the relationship of predicative verbs.
Suggested change
| + When the remaining available storage in `tmp-storage-path` is lower than the value defined by `temp-storage-quota`, the TiDB server reports an error when it is started and exits. | |
| + When the remaining available storage in `tmp-storage-path` is lower than the value defined by `temp-storage-quota`, the TiDB server reports an error when it is started, and exits. |
ran-huang
added
status/PTAL
|
@ran-huang, @Yisaer, PTAL. |
1 similar comment
|
@ran-huang, @Yisaer, PTAL. |
Yisaer
approved these changes
Apr 21, 2020
TomShawn
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #2363 |
sre-bot
added a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add a new config
temp-storage-quotain tidb-server config document.Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?