-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference/configuration: update tidb-server configuration #2685
Conversation
Co-Authored-By: Feng Liyuan <darktemplar.f@gmail.com>
@@ -33,6 +33,14 @@ TiDB 配置文件比命令行参数支持更多的选项。你可以在 [config/ | |||
+ 默认值:`<操作系统临时文件夹>/tidb/tmp-storage` | |||
+ 此配置仅在 `oom-use-tmp-storage` 为 true 时有效。 | |||
|
|||
### `temp-storage-quota` | |||
|
|||
+ 当 `oom-use-tmp-storage` 开启时,对于 `tmp-storage-path` 存储使用的限额,单位为字节。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得前半句不用了。 不然这句信息太多。
cc @zz-jason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
### `temp-storage-quota` | ||
|
||
+ 当 `oom-use-tmp-storage` 开启时,对于 `tmp-storage-path` 存储使用的限额,单位为字节。 | ||
+ 当 `tmp-storage-path` 的剩余可用容量低于 `temp-storage-quota` 所定义的值时,tidb-server 启动时将会报出错误并退出。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句可以放到最后
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-4.0 in PR #2728 |
What is changed, added or deleted? (Required)
add new configuration in tidb-server configuration document
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?
pingcap/tidb#15700