config: support temporary storage usage limitation #15700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yisaer, you already got 250 points from easy level tasks when all pull requests merged. And you will not get score from this PR. |
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
SunRunAway
reviewed
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #15700 +/- ##
===========================================
Coverage 80.4050% 80.4050%
===========================================
Files 505 505
Lines 135729 135729
===========================================
Hits 109133 109133
Misses 18100 18100
Partials 8496 8496 |
ghost
requested review from
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
qw4990
previously approved these changes
Apr 8, 2020
qw4990
added
the
status/can-merge
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-integration-copr-test |
added 2 commits
April 8, 2020 21:54
SunRunAway
approved these changes
Apr 8, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 16130 |
|
/run-all-tests |
SunRunAway
added
release-note
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-4.0 in PR #16211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #13983
UCP: #13983
Problem Summary:
What is changed and how it works?
How it Works:
Add
TempStorageQuota(bytes) in config which describe the temporary storage quota for the tidb-server.If the
quotaexceed the capacity of the target directory which defined byTempStoragePath, the server would exit with the fatal error.And we use a GlobalDiskTracker to track the disk usage for the executor, if the executor exceeds its disk quota, the query would be killed with
Out of Global Storage.Check List
Tests
Release note
Support temporary storage usage limitation for tidb-server