Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: allow_invalid_dates is now supported #853

Merged
merged 2 commits into from
Jan 28, 2019
Merged

sql: allow_invalid_dates is now supported #853

merged 2 commits into from
Jan 28, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jan 15, 2019

@morgo morgo added the v3.0 label Jan 15, 2019
@morgo
Copy link
Contributor Author

morgo commented Jan 15, 2019

PTAL @jackysp , @CaitinChen

@morgo morgo requested review from CaitinChen and jackysp January 15, 2019 02:06
@morgo
Copy link
Contributor Author

morgo commented Jan 15, 2019 •
edited
Loading

Actually, I didn't realize #771 was not merged. I will close this request and combine the two.

Edit: It's an old PR, I thought it covered more on sql modes. This seems unrelated, so I will keep it in this PR.

@morgo morgo closed this Jan 15, 2019
@morgo morgo reopened this Jan 15, 2019
jackysp
jackysp reviewed Jan 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo
Copy link
Contributor Author

morgo commented Jan 25, 2019

Feedback addressed. @CaitinChen PTAL

CaitinChen
CaitinChen approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen merged commit c4b9fa8 into master Jan 28, 2019
@CaitinChen CaitinChen deleted the morgo/sql-mode-update branch January 28, 2019 02:58
yikeke pushed a commit to yikeke/docs-cn that referenced this pull request Jan 29, 2019
sql: allow_invalid_dates is now supported
3960ab3 
Via: pingcap/docs#853
@yikeke yikeke mentioned this pull request Jan 29, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@CaitinChen CaitinChen CaitinChen approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @jackysp @CaitinChen @sre-bot