Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Default changes from TIDB master #771

Closed
wants to merge 7 commits into from
Closed

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 26, 2018

These changes AFAIK are in master only, and have not been backported to TiDB 2.1:

@morgo morgo requested a review from QueenyJin January 14, 2019 02:31
@morgo
Copy link
Contributor Author

morgo commented Jan 14, 2019

@queenypingcap This PR is ready to merge when the docs is ready for master-branch-only content.

@morgo morgo changed the title [WIP] sql: Default changes from TIDB master sql: Default changes from TIDB master Jan 14, 2019
@lilin90
Copy link
Member

lilin90 commented Jan 14, 2019

@morgo Does this change only apply to TiDB 3.0? If yes, we can merge this PR add a v3.0 label.

@morgo morgo added the v3.0 label Jan 14, 2019
@morgo
Copy link
Contributor Author

morgo commented Jan 14, 2019

@lilin90 yes, that's correct.

Co-Authored-By: morgo <tocker@gmail.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo added the DNM label Mar 26, 2019
@morgo
Copy link
Contributor Author

morgo commented Mar 26, 2019

Let's DNM the 3.0 PRs until after DITA and version split.

@morgo morgo added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jun 24, 2019
@morgo
Copy link
Contributor Author

morgo commented Jun 24, 2019

Superseded by #1253

@morgo morgo closed this Jun 24, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@lilin90 lilin90 deleted the morgo-update-master branch February 10, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants