-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: Set foreign_key_checks = OFF #8358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add variable validation to show warning when attempting to enable. Makes it clearer to users that TiDB does not yet support FKs
LGTM |
@morgo Please add a unit test case. |
/run-all-tests |
/run-all-tests |
zz-jason
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
contribution
This PR is from a community contributor.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Partially address #8349 by making metadata clearer that foreign keys are not supported.
What is changed and how it works?
This does two things:
foreign_key_checks
toOFF
(differs from MySQL default)foreign_key_checks
toON
. Since this is not supported by TiDB.Check List
Tests
I've manually verified it works. It does not actively change code, since it is currently an unused option - but I can add unit tests if desired.
Code changes
Side effects
Related changes
tidb-ansible
repository (I'm not sure - I don't think it is required).This change is