Support tso service #1038
Closed
Support tso service #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rleungx
force-pushed
the
tso
branch
3 times, most recently
from
93a760b
to
f827317
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
@binshi-bing Would you like to take a look? |
binshi-bing
reviewed
Jan 23, 2023
| @@ -0,0 +1,42 @@ | |||
| syntax = "proto3"; | |||
| package tsopb; | |||
There was a problem hiding this comment.
According to our last sync, my understanding is that we'll provide these APIs as storage interface used by tso service internal.
binshi-bing
reviewed
Jan 23, 2023
| option (gogoproto.unmarshaler_all) = true; | ||
| option (rustproto.lite_runtime_all) = true; | ||
|
|
||
| service Tso { |
There was a problem hiding this comment.
This service is to provide TSO storage. Shall we call it TsoStorage to differentiate it from the TSO service which provide GetTSs?
binshi-bing
reviewed
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Leung rleungx@gmail.com