Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate TSO into an independent service #5836

Closed
rleungx opened this issue Jan 9, 2023 · 7 comments · Fixed by #6171
Closed

Separate TSO into an independent service #5836

rleungx opened this issue Jan 9, 2023 · 7 comments · Fixed by #6171
Assignees
Labels
type/development The issue belongs to a development tasks

Comments

@rleungx
Copy link
Member

rleungx commented Jan 9, 2023

Development Task

@rleungx rleungx added the type/development The issue belongs to a development tasks label Jan 9, 2023
@binshi-bing
Copy link
Contributor

assign to me?

@rleungx
Copy link
Member Author

rleungx commented Jan 9, 2023

assign to me?

Yes, but I cannot find you on the assignee list previously. lol

@binshi-bing
Copy link
Contributor

binshi-bing commented Feb 2, 2023

To separate TSO into an independent service #5836, we define a new TSO service in protobuf to wraps up all the TSO related rpcs, then we can start a gPRC server which provides TSO service only.

Separate TSO into an independent service (Deadline: 02/20/2023)

Pre-work tracked below

Deployment Tasks @binshi-bing @lhy1024 @rleungx

Describe alternatives you've considered

Without defining a new TSO service in protobuf, the TSO microservice needs to be provided by the original all-in-one PD gPRC server which also registers all other services and initializes all configurations and many other things unnecessarily. It will be harder to decouple TSO service/module from other services/modules and to evolve to an independent Tenant TSO service.

Teachability, Documentation, Adoption, Migration Strategy

@binshi-bing
Copy link
Contributor

binshi-bing commented Feb 2, 2023

@rleungx could you grant me the write permission to this issue?

ti-chi-bot added a commit that referenced this issue Feb 3, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 6, 2023
Issue Number: ref tikv#5836

Signed-off-by: binshi-bing <binshi.bing@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 6, 2023
Issue Number: ref tikv#5836

Signed-off-by: binshi-bing <binshi.bing@gmail.com>
@binshi-bing
Copy link
Contributor

binshi-bing commented Feb 6, 2023

Define an independent TSO gRPC server pingcap/kvproto#1053

binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 6, 2023
Issue Number: ref tikv#5836

Signed-off-by: binshi-bing <binshi.bing@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 7, 2023
Issue Number: ref tikv#5836

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Feb 7, 2023
ref #5836

A service in different mode has different config struct and initialization logic, so we need to abstract an interface to create server.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 7, 2023
Issue Number: ref tikv#5836

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 8, 2023
Issue Number: ref tikv#5836

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Feb 8, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 8, 2023
Issue Number: ref tikv#5836

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing added a commit to binshi-bing/pd that referenced this issue Feb 9, 2023
Issue Number: ref tikv#5836

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
ti-chi-bot added a commit that referenced this issue Feb 9, 2023
ref #5836, ref #5858

This PR added the skeleton along the E2E path to initialize the TSO microservice.
It mainly contains the following change:

1. Parse the subcommands from the command line arguments and refactor the entrypoints for all-in-one pd service and other independent microservice. Needs to compare with @lhy1024's recent PR #5858
2. Refactor Server/TSO config. 
3. Add the skeleton alone E2E path to initialize the TSO microservice.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this issue Mar 16, 2023
ref #5836, close #6143

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this issue Mar 16, 2023
… struct (#6171)

close #5836

Register tso/resource_manager services with ServiceRegistryEntry json struct

Signed-off-by: Bin Shi <binshi.bing@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit that referenced this issue Mar 16, 2023
ref #5836

Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot pushed a commit that referenced this issue Mar 16, 2023
ref #5836

Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot pushed a commit that referenced this issue Mar 20, 2023
…so primary to tsopb.Participant (#6160)

ref #5836

Support tso service switched between PD mode and API mode;
Add server/client implemenation for the GetClusterInfo rpc
Add tsopb.Participant as the value type of tso primary

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
ti-chi-bot added a commit that referenced this issue Mar 21, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
This was referenced Mar 22, 2023
ti-chi-bot pushed a commit that referenced this issue Mar 23, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Mar 23, 2023
ref #5836, ref #6212

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Mar 29, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit that referenced this issue Mar 30, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot added a commit that referenced this issue May 9, 2023
ref #5836

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
zeminzhou pushed a commit to zeminzhou/pd that referenced this issue May 10, 2023
)

ref tikv#5836

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
)

ref tikv#5836

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue Nov 10, 2023
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2023
ref tikv#5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
ref #5836

Since the TSO service does not support the TSO Follower Proxy, enabling it in this case should fail.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot added a commit that referenced this issue Mar 7, 2024
ref #5836

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/development The issue belongs to a development tasks
Projects
None yet
3 participants