scheduler: move init function #5934
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
lhy1024
added
type/refactor
Codecov ReportBase: 75.53% // Head: 75.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5934 +/- ##
==========================================
- Coverage 75.53% 75.53% -0.01%
==========================================
Files 345 346 +1
Lines 35132 35133 +1
==========================================
Hits 26538 26538
- Misses 6304 6314 +10
+ Partials 2290 2281 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
LGTM. Other alternatives might be Package plugin or k8s sidecar as the mid/long term solutions.
|
@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -136,6 +135,7 @@ func createServerWrapper(args []string) (context.Context, context.CancelFunc, ba | |||
| if err != nil { | |||
| log.Fatal("create server failed", errs.ZapError(err)) | |||
| } | |||
| schedulers.Register() | |||
There was a problem hiding this comment.
Other alternatives might be Package plugin or k8s sidecar as the mid/long term solutions.
ti-chi-bot
added
status/LGT2
|
/merge |
|
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 8b710b9
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: lhy1024 admin@liudos.us
What problem does this PR solve?
Issue Number: Ref #5837
What is changed and how does it work?
Check List
Tests
Release note