-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tso grpc service include both server side and client side in a basic manner #5986
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @binshi-bing. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 75.15% // Head: 75.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5986 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 362 363 +1
Lines 36316 36322 +6
=======================================
+ Hits 27292 27297 +5
Misses 6655 6655
- Partials 2369 2370 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
749e777
to
9686407
Compare
9686407
to
f337514
Compare
f337514
to
6444e71
Compare
9006faf
to
546b7c9
Compare
546b7c9
to
f3bef7e
Compare
d198441
to
1ac5635
Compare
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Remove the rpcs SyncMaxTS, GetDCLocationInfo, SetExternalTimestamp and GetExternalTimestamp for now. These rpcs depend on the global tso allocator and some other related data structures which depend on pdpb messages, so they can't be used by tso service before futher refactor on these data structures. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
TODO: Refactor and share the TSO streaming framework in the PD client. The implementation in this change is in a very basic manner and only for testing and integration purpose -- no batching, no async, no pooling, no forwarding, no retry and no deliberate error handling. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
1ac5635
to
6e446c9
Compare
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly, LGTM
…tLocalTSWithinKeyspaceAsync() in TSOClient. Remove the basic implementation of GetTSWithinKeyspace for now and will integrate TSOClient with PDClient's TSO batching/forwarding/async/pooling framework in the next few prs. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
b905264
to
4228db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need more tests and remove duplicate code later
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4228db8
|
/ok-to-test |
What problem does this PR solve?
This change implements tso grpc service include both server side and client side.
The corresponding kvproto pr is here pingcap/kvproto#1053.
Issue Number: Ref #5836
What is changed and how does it work?
This pr is split from "basic implement tso gPRC service #5949".
This pr only implements Tso() rpc. SyncMaxTS, GetDCLocationInfo, SetExternalTimestamp and GetExternalTimestamp rpcs depend on the global tso allocator and some other related data structures which are tightly coupled with pdpb messages, so they can't be used by tso service before further refactor on these data structures. And this pr #5949 is the version which refactors and reuses server/grpc_server.go to avoid duplicate code as much as possible.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note