Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: make test stable #6047

Merged
merged 3 commits into from
Feb 24, 2023
Merged

resource_manager: make test stable #6047

merged 3 commits into from
Feb 24, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 24, 2023

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 74.88% // Head: 74.79% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (c6036fb) compared to base (2d8e79f).
Patch coverage: 57.14% of modified lines in pull request are covered.

❗ Current head c6036fb differs from pull request most recent head e8f707d. Consider uploading reports for the commit e8f707d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6047      +/-   ##
==========================================
- Coverage   74.88%   74.79%   -0.09%     
==========================================
  Files         367      367              
  Lines       36592    36588       -4     
==========================================
- Hits        27402    27367      -35     
- Misses       6801     6824      +23     
- Partials     2389     2397       +8     
Flag Coverage Δ
unittests 74.79% <57.14%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/server/server.go 47.77% <57.14%> (-0.29%) ⬇️
pkg/tso/local_allocator.go 62.16% <0.00%> (-16.22%) ⬇️
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-4.55%) ⬇️
pkg/tso/allocator_manager.go 61.45% <0.00%> (-4.20%) ⬇️
pkg/id/id.go 83.05% <0.00%> (-3.39%) ⬇️
pkg/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
pkg/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 77.77% <0.00%> (-1.02%) ⬇️
server/cluster/cluster.go 81.49% <0.00%> (-0.90%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -250,6 +250,8 @@ func (s *Server) startServer() error {
if err != nil {
return err
}
s.cfg.ListenAddr = strings.TrimPrefix(s.cfg.ListenAddr, "http://")
s.cfg.ListenAddr = strings.TrimPrefix(s.cfg.ListenAddr, "https://")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use more general function

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2023
@rleungx
Copy link
Member

rleungx commented Feb 24, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c6036fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2023
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b2f2a82 into tikv:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants