Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register tso/resource_manager services with ServiceRegistryEntry json struct #6171

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

binshi-bing
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #5836

What is changed and how does it work?

Register tso/resource_manager services with ServiceRegistryEntry json struct

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Hi @binshi-bing. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… struct

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 16, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 948de91

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 16, 2023

--- FAIL: TestServerRegisterTestSuite/TestServerRegister (0.08s)
        register_test.go:91: 
            	Error Trace:	/home/runner/work/pd/pd/tests/mcs/discovery/register_test.go:91
            	            				/home/runner/work/pd/pd/tests/mcs/discovery/register_test.go:69
            	Error:      	Not equal: 
            	            	expected: "http://127.0.0.1:35379/"
            	            	actual  : "{\"serviceAddr\":\"[http://127.0.0.1:35379\](http://127.0.0.1:35379/)"}"

plz update test

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 711c22e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 47.36% and project coverage change: -0.12 ⚠️

Comparison is base (bc12668) 74.40% compared to head (d137ac4) 74.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6171      +/-   ##
==========================================
- Coverage   74.40%   74.28%   -0.12%     
==========================================
  Files         392      393       +1     
  Lines       38336    38353      +17     
==========================================
- Hits        28523    28491      -32     
- Misses       7289     7324      +35     
- Partials     2524     2538      +14     
Flag Coverage Δ
unittests 74.28% <47.36%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/discovery/registry_entry.go 33.33% <33.33%> (ø)
pkg/mcs/resource_manager/server/server.go 59.22% <60.00%> (-0.17%) ⬇️
pkg/mcs/tso/server/server.go 50.80% <60.00%> (-0.02%) ⬇️

... and 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot
Copy link
Member

@binshi-bing: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 266c021 into tikv:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate TSO into an independent service
4 participants