Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LockType field into proto LockInfo #472

Merged
merged 2 commits into from
Oct 18, 2019
Merged

add LockType field into proto LockInfo #472

merged 2 commits into from
Oct 18, 2019

Conversation

cfzjywxk
Copy link
Contributor

add LockType in LockInfo struct

default 0 means common lock, '1' means pessimistic lock

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jackysp
jackysp reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp previously approved these changes Oct 18, 2019
View reviewed changes
@coocood
Copy link
Member

coocood commented Oct 18, 2019

We can use Op as the type https://github.com/pingcap/kvproto/blob/master/proto/kvrpcpb.proto#L137

@cfzjywxk
Copy link
Contributor Author

We can use Op as the type https://github.com/pingcap/kvproto/blob/master/proto/kvrpcpb.proto#L137

@coocood
for common lock, the op value is 2 not 0, do we need to make the lockType default value 0 ?

@coocood
Copy link
Member

coocood commented Oct 18, 2019

We can just check if the Op is pessimistic lock

@cfzjywxk cfzjywxk mentioned this pull request Oct 18, 2019
Merged
coocood
coocood approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youjiali1995 youjiali1995 merged commit 75b7eba into pingcap:master Oct 18, 2019
@cfzjywxk cfzjywxk deleted the lockType branch October 18, 2019 06:15
@youjiali1995 youjiali1995 mentioned this pull request Oct 18, 2019
Merged
sticnarf pushed a commit to sticnarf/kvproto that referenced this pull request Oct 27, 2019
@cfzjywxk @youjiali1995
add LockType field into proto LockInfo (pingcap#472)
f8b330b 
* add LockType field into proto LockInfo
cfzjywxk added a commit to cfzjywxk/kvproto that referenced this pull request Nov 5, 2019
@cfzjywxk
cherry-pick master pingcap#484 pingcap#472 to release 3.0
62de7b8 
add LockType field and Op field for pessimistic lock
@cfzjywxk cfzjywxk mentioned this pull request Nov 5, 2019
Merged
youjiali1995 pushed a commit that referenced this pull request Nov 6, 2019
@cfzjywxk @youjiali1995
cherry-pick master #484 #472 to release 3.0 (#486)
c5d88d6 
add LockType field and Op field for pessimistic lock
overvenus pushed a commit that referenced this pull request Jan 9, 2020
@cfzjywxk @overvenus
add LockType field into proto LockInfo (#472)
6e3cffc 
* add LockType field into proto LockInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@jackysp jackysp jackysp approved these changes

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cfzjywxk @CLAassistant @coocood @jackysp @youjiali1995