Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PessimisticLock: signed wait timeout #484

Merged
merged 2 commits into from
Nov 1, 2019
Merged

PessimisticLock: signed wait timeout #484

merged 2 commits into from
Nov 1, 2019

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

@youjiali1995
PessimisticLock: signed wait timeout
453e172 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
coocood
coocood previously approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Nov 1, 2019

@sticnarf PTAL

@coocood
Copy link
Member

coocood commented Nov 1, 2019

@MyonKeminta PTAL

sticnarf
sticnarf reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to comment for what negative value means?

@coocood
Copy link
Member

coocood commented Nov 1, 2019

Maybe better to comment for what negative value means?

+1
And comment for 0 value means default.

@youjiali1995
Copy link
Contributor Author

@coocood @sticnarf PTAL again. Thanks!

sticnarf
sticnarf reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coocood
coocood previously approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youjiali1995
add comment
105fda1 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
jackysp
jackysp previously approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youjiali1995 youjiali1995 dismissed stale reviews from jackysp and coocood via 105fda1 November 1, 2019 06:24
@coocood coocood merged commit 76b56d6 into pingcap:master Nov 1, 2019
@youjiali1995 youjiali1995 deleted the signed-wait-timeout branch November 1, 2019 06:29
cfzjywxk added a commit to cfzjywxk/kvproto that referenced this pull request Nov 5, 2019
@cfzjywxk
cherry-pick master pingcap#484 pingcap#472 to release 3.0
62de7b8 
add LockType field and Op field for pessimistic lock
@cfzjywxk cfzjywxk mentioned this pull request Nov 5, 2019
Merged
youjiali1995 pushed a commit that referenced this pull request Nov 6, 2019
@cfzjywxk @youjiali1995
cherry-pick master #484 #472 to release 3.0 (#486)
c5d88d6 
add LockType field and Op field for pessimistic lock
overvenus pushed a commit that referenced this pull request Jan 9, 2020
@youjiali1995 @overvenus
PessimisticLock: signed wait timeout (#484)
db3114c
daimashusheng pushed a commit to daimashusheng/kvproto that referenced this pull request Sep 2, 2021
@youjiali1995 @coocood
PessimisticLock: signed wait timeout (pingcap#484)
e821110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@coocood coocood coocood approved these changes

@jackysp jackysp jackysp left review comments

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youjiali1995 @coocood @jackysp @sticnarf